New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to negotiate a peer should not take down the listener #417

Open

ralexstokes opened this issue May 24, 2020 · 0 comments

Contributor

ralexstokes commented May 24, 2020

It seems that an exception in this function:

https://github.com/libp2p/py-libp2p/blob/master/libp2p/network/swarm.py#L234

results in the swarm (?) throwing an exception which takes down the entire listener.

We should catch failures in peer negotiation appropriately so this doesn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment