Way to declare Choice with nested Choice?

[anthok]

Trying to declare a choice within a choice and getting the following error
Custom { msg: "CHOICE-style enums do not allow implicit tagging. If using the derive macro on a sequence with a choice field ensure it is marked with `#[rasn(choice)]`." }'

Pretty sure the error relates to NameObjects but not sure how to fix it.

ASN1

ProtocolMessages::= CHOICE
{
	message[0] 	IMPLICIT MessagePDU,
}

MessagePDU::= SEQUENCE
{
	messageID			INTEGER,
	nameObjects                   NameObjects
}

NameObjects::= CHOICE
{
	getNameList			[1] 	IMPLICIT GetNameListRequest,
	read				[4]	IMPLICIT ReadRequest,
	write				[5]	IMPLICIT WriteRequest,
	getVariableAccessAttributes	[6]	GetVariableAccessAttributesRequest,
	defineNamedVariableList		[11]	IMPLICIT DefineNamedVariableListRequest,
	getNamedVariableListAttributes	[12] GetNamedVariableListAttributesRequest,
	deleteNamedVariableList		[13]	IMPLICIT DeleteNamedVariableListRequest
}

GetVariableAccessAttributesRequest::= CHOICE {
	nameId		[0] INTEGER
}

Rust

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
#[rasn(choice)]
pub enum ProtocolMessages{
    #[rasn(tag(0))]
    message(MessagePDU),
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
pub struct MessagePDU{
    messageID: rasn::types::Integer,
    
    #[rasn(choice)]
    nameObjects: NameObjects,
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
#[rasn(choice)]
enum NameObjects {
    // commented out all the others...
    #[rasn(choice)]
    #[rasn(tag(6))]
    getVariableAccessAttributes(GetVariableAccessAttributesRequest),
}
    
#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
#[rasn(choice)]
enum GetVariableAccessAttributesRequest {
    #[rasn(tag(0))]
    nameId(rasn::types::Integer),
}

[XAMPPRocky]

Heh, Thank you for your question! If you use the latest main it should work, I need to fix a couple issues and then cut a new release before then.

[anthok]

you rock Rocky!

[anthok]

Ran into an issue using the latest main, here's a more nested unit test that's showing the issue.
Encoding field of type `NestedEnum`: CHOICE-style enums do not allow implicit tagging.

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
#[rasn(choice)]
pub enum ProtocolMessages {
    #[rasn(tag(0))]
    Message(MessagePDU),
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
pub struct MessagePDU {
    message_id: rasn::types::Integer,
    name_objects: NameObjects,
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
#[rasn(choice)]
enum NameObjects {
    #[rasn(tag(0))]
    TestObject(TestObject),
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
pub struct TestObject {
    #[rasn(tag(0))]
    nested_enum: NestedEnum,
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
#[rasn(choice)]
enum NestedEnum {
    #[rasn(tag(0))]
    NestObject(NestObject),
}

#[derive(AsnType, Decode, Encode, Debug, PartialEq, Clone)]
pub struct NestObject {
    #[rasn(tag(0))]
    nested_value: rasn::types::Integer,
}

#[test]
fn it_works() {
    let data = ProtocolMessages::Message(MessagePDU {
        message_id: 0.into(),
        name_objects: NameObjects::TestObject(TestObject {
            nested_enum: NestedEnum::NestObject(NestObject {
                nested_value: 0.into(),
            }),
        }),
    });

    let bin = rasn::ber::encode(&data).unwrap();
    assert_eq!(data, rasn::ber::decode(&bin).unwrap());
}

[XAMPPRocky]

This is fixed on the latest on main. In the future, if you find any more bugs could you file them as new issues?

[anthok]

Of course! Sorry I wasn't sure if it was a bug or me doing something silly. Thanks again!

[XAMPPRocky]

No worries, thanks for the report! 🙂