Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom map feature will not reflect a name change of devices #15992

Open
jaxjexjox opened this issue Apr 29, 2024 · 4 comments
Open

Custom map feature will not reflect a name change of devices #15992

jaxjexjox opened this issue Apr 29, 2024 · 4 comments

Comments

@jaxjexjox
Copy link

jaxjexjox commented Apr 29, 2024

The problem

The name for objects in the new custom map, appears to be derived based on the "Display Name" of the object.

If you change the display name of an object the custom map will not not reflect said name change and retains the old name.

https://i.imgur.com/OBEeoSE.png <- these 2 are the exact same device on our network.

Output of ./validate.php

Component | Version
--------- | -------
LibreNMS  | 24.4.1 (2024-04-21T00:26:51+10:00)
DB Schema | 2024_04_10_093513_remove_device_perf (291)
PHP       | 8.2.18
Python    | 3.10.12
Database  | MariaDB 10.10.7-MariaDB-1:10.10.7+maria~ubu2204
RRDTool   | 1.7.2
SNMP      | 5.9.1
===========================================

[OK]    Composer Version: 2.7.4
[OK]    Dependencies up-to-date.
[OK]    Database connection successful
[OK]    Database Schema is current
[OK]    SQL Server meets minimum requirements
[OK]    lower_case_table_names is enabled
[OK]    MySQL engine is optimal
[OK]    Database and column collations are correct
[OK]    Database schema correct
[OK]    MySQL and PHP time match
[OK]    Active pollers found
[OK]    Dispatcher Service not detected
[OK]    Locks are functional
[FAIL]  Some poller nodes have not checked in recently
        Inactive Nodes:
         13a6c113c673
[OK]    Redis is unavailable
[OK]    rrdtool version ok
[OK]    Connected to rrdcached

What was the last working version of LibreNMS?

No response

Anything in the logs that might be useful for us?

I suspect this is a simple design issue, the 'custom-map' feature (and again, my god, thank you so much for this!!) is not referring to some kind of unique identifier?

I would be inclined to link to the actual object entry such as the actual 'device number' perhaps?
http://URLFORLIBRENMS.INTERNALDOMAIN:PORT/device/3  <-  note the 3?


WHILE I HAVE YOU .........
Please do consider this design change for icon / object labelling?

https://i.imgur.com/FtcOlbY.png

(in other words, I'd love a 'box border labelling' around the titles for the objects I put down, despite the custom device icon)

@librenms-bot
Copy link

This issue has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/feature-new-custom-map-feature-integration-with-devices-direct-page/24285/5

@murrant
Copy link
Member

murrant commented May 6, 2024

Names in the custom maps are independent of anything else. It probably is a new feature to implement that.

@jaxjexjox
Copy link
Author

I'm not sure how I feel about the design decision there. I can totally see how a custom name would be useful for the sake of a map but it does somewhat 'break' linking devices too.

Is this feature being worked on in general? Do you know.

@murrant
Copy link
Member

murrant commented May 16, 2024

@jaxjexjox it is a very new feature. Still consensus being formed on how it should work.

As I said it would be a feature to add a feature where the name follows the display name instead of being independent. For my use case it is nice that it is independent, because I sometimes have a single device representing an entire location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants