unix: fix signal handling data race #4287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the `caught_signals` field should be immediately visible to other threads, otherwise "we get signal" events can get lost. Tentative fix for the linked issue. I say "tentative" because the cause is not fully understood but all signs point to libuv's handling of SIGCHLD signals, and they only manifest on architectures with weaker memory models than x86. Fixes: libuv#4279
bnoordhuis
commented
Jan 15, 2024
|
I tested this in the environment described in #4279, and it does not resolve the issue. The symptoms remain identical. |
|
Yes, I realized a day later that Rosetta runs the ARM CPU in TSO (Total Store Ordering) mode, same as x86. Whatever it is, it can't be the weaker memory model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the
caught_signalsfield should be immediately visible to other threads, otherwise "we get signal" events can get lost.Tentative fix for the linked issue. I say "tentative" because the cause is not fully understood but all signs point to libuv's handling of SIGCHLD signals, and they only manifest on architectures with weaker memory models than x86.
Fixes: #4279