Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: misleading comments in tty.c #4298

Open
rillig opened this issue Feb 3, 2024 · 0 comments
Open

windows: misleading comments in tty.c #4298

rillig opened this issue Feb 3, 2024 · 0 comments

Comments

@rillig
Copy link

rillig commented Feb 3, 2024

  • Version: v.1.x
  • Platform: Windows

The file src/win/tty.c contains these comments:

  • Prefix with \u033 if alt was held, …
  • Prefix with \x033 when the alt key was held.

These comments are misleading:

  • \u suggests a Unicode code point interpretation, which is hexadecimal.
  • \x is hexadecimal.
  • The prefixes in the actual code are octal though.

The comments should use the same wording, as far as possible, and the correct escape sequence (if that's necessary at all to understand the code).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rillig