Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Read Buffer Size [rt.cpan.org #105184] #59

Open
oalders opened this issue Mar 31, 2017 · 3 comments
Open

Fixed Read Buffer Size [rt.cpan.org #105184] #59

oalders opened this issue Mar 31, 2017 · 3 comments

Comments

@oalders
Copy link
Member

oalders commented Mar 31, 2017

Migrated from rt.cpan.org#105184 (status was 'new')

Requestors:

From dam6923@gmail.com on 2015-06-12 04:03:33:

Hello,

I have discovered much better performance when increasing the size of
the buffer responsible for reading a file when DYNAMIC_FILE_UPLOAD is
set to true.  It's current a fixed size of 2048.  Please increase this
to a more modern number (Java uses 8192 by default for buffered file
reads) and/or allow this to be a configurable option.

Thanks!
@neilb
Copy link
Contributor

neilb commented Oct 14, 2022

This seems pretty harmless to bump up to 8192, and it could be made a package variable, so it can be overridden if someone wants to, but probably not document that. I don't think it's worth providing a formal interface for changing it?

Shall I do a PR?

@oalders
Copy link
Member Author

oalders commented Oct 14, 2022

That sounds great to me. @haarg?

@oalders
Copy link
Member Author

oalders commented Oct 25, 2022

Closed via #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants