HTTP::Config->match generates "uninitialized value" in matching method [rt.cpan.org #115670]

[oalders]

Migrated from rt.cpan.org#115670 (status was 'new')

Requestors:

• branislav.zahradnik@gooddata.com

From branislav.zahradnik@gooddata.com on 2016-06-28 13:24:50:

Use case: LWP::UserAgent response redirect handler with matching
specific response header, eg "Client-Warning"

Current code:
    m_header__ => sub {
        my($v, $k, $uri, $request, $response) = @_;
        return unless $request;
        return 1 if $request->header($k) eq $v;
        return 1 if $response && $response->header($k) eq $v;
        return 0;
    },

Quick fix:

    m_header__ => sub {
        my($v, $k, $uri, $request, $response) = @_;
        return unless $request;
        return 1 if $request->header($k) && $request->header($k) eq $v;
        return 1 if $response && $response->header($k) &&
$response->header($k) eq $v;
        return 0;
    },

or just disable warnings in those lamdas.

[openstrike]

I have tried to formulate a test for this prior to fixing it but have been unable to reproduce the reported problem. There are 2 additional tests in t/http-config.t in https://github.com/openstrike/HTTP-Message/tree/issue-62 both of which pass.

Have I missed an important detail? Given that there is no "match" method I've used matching_items() as in the other tests in that file.