-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddressSanitzer et al. exit leaves terminal echo disabled. #26
Comments
Based on what some other projects do, I'd suggest:
|
Anyone has a patch for this? |
Not yet. I think the first one wouldn't be all that much clutter to xmp, and ideally it'd just suppress the player display portion of the terminal output (which is presumably the reason echo/etc is changed). The driver portion could just be handled with the driver flag, if needed (WAV output or playback might be desirable in some cases). It'd also be good to have a way to target any arbitrary one of the four xmp_load_module* functions. edit: |
When xmp is terminated by AddressSanitizer, MemorySanitizer, etc. encountering an error and exiting, terminal echo is still turned off until manually fixed with
stty echo
,tput reset
, or similar. I don't know what the correct solution is for this, but I tried adding anatexit
hook to callreset_tty
and it didn't help. This has been mildly annoying when diagnosing issues like libxmp/libxmp#319 with input files that cause a lot of ASan/MSan exits.The text was updated successfully, but these errors were encountered: