Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an option to duplicate chapters in studies #15256

Open
adityaraute opened this issue May 8, 2024 · 7 comments
Open

Create an option to duplicate chapters in studies #15256

adityaraute opened this issue May 8, 2024 · 7 comments

Comments

@adityaraute
Copy link

I was creating a study for an opening and was frustrated at the fact that we cannot simply duplicate chapters in the same study.
I am expected to export PGN then create a new chapter and import the PGN.
It will be much more smoother for our User Experience to simply add an option to duplicate the chapter.
Simple but effective addition to the Study tool.

@allanjoseph98
Copy link
Contributor

This already exists. When creating a new chapter from PGN, you get the option to import from the currently viewed chapter in bright blue letters.

@randompearl-stack
Copy link
Contributor

@adityaraute
Copy link
Author

Thanks @allanjoseph98 and @randompearl-stack ,
I apologise for the oversight here.

However, I have a few qualms about this.

  1. I feel it doesn't need to be under PGN. Why can't it be on the first page of the menu, outside of the Empty-Editor-etc menu?
  2. I can only import from the current selected chapter. Instead a dropdown may be useful? Or even more intuitive would be to simply add the 'Duplicate Chapter' option in the settings menu of an existing chapter. Makes sense?

@schlawg
Copy link
Collaborator

schlawg commented May 8, 2024

Adding it to the Edit Chapter menu comes with its own challenge. Namely, how does the duplicate operation interact with existing form controls (such as Name), which might be in a dirty state.

Maybe worth exploring:

  • Change gear behavior to display a popup menu with Delete, Duplicate, Edit items. Delete would just launch a confirmation dialog and Duplicate will either launch a "choose name" dialog or the Edit chapter dialog with a generated name (Chapter 1 Copy 6), which ostensibly they will change and then click Save. And of course choosing the edit item would be just like clicking the gear was previously.

  • Leave gear alone but create a right-click/long-press context menu on the chapter list with the same items as above. This preserves existing gear behavior and simplifies duplicate/delete at the cost of discoverability (who knew there's a context menu)

@adityaraute
Copy link
Author

Adding it to the Edit Chapter menu comes with its own challenge. Namely, how does the duplicate operation interact with existing form controls (such as Name), which might be in a dirty state.

If Name is the only field that is a problem, it can be simply suffixed by '- Copy' which the user can later rename as necessary.
No other field in my opinion needs to be verified as the other field behaviour will be the exact same as for the current chapter.

@schlawg
Copy link
Collaborator

schlawg commented May 8, 2024

What if it has already been changed by the user, but not saved?

@adityaraute
Copy link
Author

Fair point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants