Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize ui/learn #15098

Open
schlawg opened this issue Apr 17, 2024 · 2 comments · May be fixed by #15263
Open

modernize ui/learn #15098

schlawg opened this issue Apr 17, 2024 · 2 comments · May be fixed by #15263
Assignees
Labels
no scala wanted Dead or alive. Backed by a regular contributor.

Comments

@schlawg
Copy link
Collaborator

schlawg commented Apr 17, 2024

  1. Get rid of mithril, seems like it's just boilerplate.
  2. Either get rid of chess.js dependency or convince this mythical ornicar person to put it in npm. some pnpm versions find github repo links in package.json offensive.
  3. Investigate compatibility with chessground 9.0.4 (learn module links to a really old version and i'd like to know why).
@schlawg schlawg added no scala wanted Dead or alive. Backed by a regular contributor. labels Apr 17, 2024
@ornicar
Copy link
Collaborator

ornicar commented Apr 17, 2024

it uses a chessground fork to display stars and maybe other garbage on the board. I don't think we should make the normal chessground any heavier just for ui/learn.

But a newer fork could be used. Heck, maybe current chessground can do it on its own, idk.

@brollin
Copy link
Collaborator

brollin commented May 5, 2024

A refactoring task that when finished, the user will never know? That's my jam. It was fun to see what people did with the coordinate trainer after that was snabbdomified.

At least from what I've seen, it does seem like most if not all of the required chessground functionality exists in the latest chessground. Namely allowing custom SVGs should get us pretty far I would think (🤞).

@brollin brollin self-assigned this May 5, 2024
@brollin brollin linked a pull request May 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no scala wanted Dead or alive. Backed by a regular contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants