Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving pieces during a broadcast #15284

Open
laurent-yin opened this issue May 11, 2024 · 1 comment
Open

Moving pieces during a broadcast #15284

laurent-yin opened this issue May 11, 2024 · 1 comment
Labels

Comments

@laurent-yin
Copy link

Exact URL of where the bug happened

https://lichess.org/broadcast/2024-superbet-poland-rapid--blitz/blitz-round-9/IwuGRcXl/xg73JH7F

Steps to reproduce the bug

  1. Go to a live broadcast with an ongoing game
  2. Move a piece

What did you expect to happen?

The moves we make during a live broadcast should be added as a variation.
The moves from the actual game should still come in and be added as the main line.
Ideally, when we are trying a variation, there should be something that indicates it (board in another color, or some visual indicator), and we should have some way of going back to the live broadcast.
There should be an indicator when we are getting the moves from the live (live icon with a red dot?)

What happened instead?

  1. It adds a move to the move sheet as the main line
  2. Moves from the live broadcast are not picked up anymore
  3. You need to refresh to come back to see the new moves

Operating system

Windows 10

Browser and version (or alternate access method)

Chrome

Additional information

I suppose there might be some reconciliation needed if the moves from the variation we're looking at happen to be the moves that are added as the main line from the live game.

@BSmick6
Copy link
Contributor

BSmick6 commented May 23, 2024

I have to take a break for now but I'm pretty sure we can resolve this issue by updating this line to modify the isMainline variable based on whether the current game is a broadcast. I can dig more into it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants