Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on analysis button in lesson opens new tab but also changes current tab #15306

Closed
danispringer opened this issue May 15, 2024 · 3 comments · Fixed by #15321
Closed

Clicking on analysis button in lesson opens new tab but also changes current tab #15306

danispringer opened this issue May 15, 2024 · 3 comments · Fixed by #15321
Labels
bug

Comments

@danispringer
Copy link

Exact URL of where the bug happened

https://lichess.org/practice/basic-tactics/the-skewer/tuoBxVE5/p0ou7kIw

Steps to reproduce the bug

Click on analysis button. A new tab is opened. but previously current tab also goes to FEN and out of less.

What did you expect to happen?

Either change active tab to analysis, or only open a new tab for it.

What happened instead?

Both happened, the active tab changed to the FEN, AND a new tab opened too

Operating system

macos

Browser and version (or alternate access method)

brave

Additional information

No response
@BSmick6
Copy link
Contributor

BSmick6 commented May 15, 2024

I'm pretty sure this issue is resolved by reverting 035867a

@danispringer
Copy link
Author

@BSmick6 so this? #14534 Me again 😅 but yeah, something seems odd with that button...
Thanks

@BSmick6
Copy link
Contributor

BSmick6 commented May 16, 2024

Yes, exactly! I should look into it more but I suspect there was some sort of bug in Safari that is fixed now.

@BSmick6 BSmick6 mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix analysis button on practice lesson boards changing current tab BSmick6/lila
2 participants
@BSmick6 @danispringer