Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom shortcuts don't work on macOS #14

Open
SynVisions opened this issue Apr 29, 2019 · 2 comments
Open

Custom shortcuts don't work on macOS #14

SynVisions opened this issue Apr 29, 2019 · 2 comments

Comments

@SynVisions
Copy link

SynVisions commented Apr 29, 2019

macOS 10.12.6
Firefox Quantum 66.0.3 (64-bit)

Even with the default shortcuts, they don't work, even when the Google Play Music tab is in focus.

Clicking on the toolbar button for the extension does the appropriate play/pause, so that part of the code is working at least. Shortcuts don't work at all for me.

@SynVisions
Copy link
Author

Ok, I ran the extension in debug mode which fixed the problem with the default shortcuts (no idea why), but the ones I want to use aren't working. Seems like they aren't translating to the right thing.

I'm now seeing this mapping happen when I close and reload the extension after setting my options.

Space -> MacSpace
Right -> MacRight
Left -> MacLeft

Similar to #13 ?

@lidel lidel changed the title Shortcuts don't work anymore Custom shortcuts don't work on macOS May 20, 2019
@lidel
Copy link
Owner

lidel commented May 20, 2019

Thank you for reporting this. Sadly I don't own a Mac and can't reproduce this.

If anyone sees this and can help a PR or a comment (even if it is "i have a mac and works for me") with will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants