Please fix rounding issues

[kaber2]

Hello guys,

could you please fix that annoying rounding issue when transferring stETH tokens?

AFAICT, it should be relatively simple as you are using a proxy architecture. An easy fix would be to upscale share values internally by 1e18. For compatibility, you could use a new balanceOf map and, if an account has no balance there, you fall back to reading from the old unscaled map. This would impose a relatively minor one time gas cost on the first transfer for every account.

Thanks!

[mymphe]

Hey @kaber2! Thanks for submitting this issue and contributing to the Lido protocol!

Your proposed solution will not work since this issue does not only occur for the initial mint but any transfer as well. However, we have some developments in this area, please see lidofinance/lido-dao#442 for more details.