Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do periodic security update (yarn audit) #2

Closed
wincent opened this issue Sep 24, 2020 · 6 comments
Closed

Do periodic security update (yarn audit) #2

wincent opened this issue Sep 24, 2020 · 6 comments
Labels
chore security

Comments

@wincent
Copy link
Contributor

wincent commented Sep 24, 2020 •
edited

This issue will substitute this currently open dependabot PR:

More context on our policy here: https://github.com/liferay/liferay-frontend-guidelines/blob/master/general/security.md
@wincent wincent added the chore label Sep 24, 2020
This was referenced Sep 24, 2020
Closed
Closed
@wincent
Copy link
Contributor Author

wincent commented Sep 25, 2020

Adding: #34 (eslint-plugin-sort-destructure-keys)

This was referenced Sep 25, 2020
Closed
Closed
@wincent
Copy link
Contributor Author

wincent commented Sep 25, 2020

Adding: #77 (eslint-plugin-react)

This was referenced Sep 25, 2020
Closed
Closed
@wincent
Copy link
Contributor Author

wincent commented Sep 28, 2020

See also: liferay/eslint-config-liferay#201 (jest, from old repo; not sure if this is still relevant here, because I see two versions of jest in our lockfile right now).

@wincent wincent mentioned this issue Sep 28, 2020
Closed
@wincent
Copy link
Contributor Author

wincent commented Sep 28, 2020

See also: liferay/liferay-npm-tools#504 (stylelint)

@wincent
Copy link
Contributor Author

wincent commented Sep 28, 2020

Adding: #86 (eslint-config-prettier)

This was referenced Sep 28, 2020
Closed
Closed
@wincent
Copy link
Contributor Author

wincent commented Oct 5, 2020

Most of these got updated in #105

So I'm closing this one, and starting a new one: #112

@wincent wincent closed this as completed Oct 5, 2020
kresimir-coko added a commit to kresimir-coko/liferay-frontend-projects that referenced this issue Jun 7, 2021
@kresimir-coko
chore: SF liferay#2
c8e2916
@bryceosterhaus bryceosterhaus mentioned this issue Nov 18, 2021
Closed
@izaera izaera mentioned this issue Oct 4, 2022
Merged
bryceosterhaus pushed a commit that referenced this issue Oct 5, 2022
@izaera
fix(alloy-ui): don't coalesce <script> nodes in aui-parse-content
bab4d04 
The previous code was merging several inline <script> nodes into a single
one which caused <script type=module> contents to fail execution because
imports appeared in the middle of the coalesced <script> tag.

See error #2
in liferay-frontend/liferay-portal#2749 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wincent