Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jest to 26.x for better API support #231

Closed
1 task done
bryceosterhaus opened this issue Nov 9, 2020 · 4 comments
Closed
1 task done

Update Jest to 26.x for better API support #231

bryceosterhaus opened this issue Nov 9, 2020 · 4 comments

Comments

@bryceosterhaus
Copy link
Member

Issue type (mark with x)

  • 馃巵 Feature request

Description

With our new support matrix for browsers, I think it would be helpful to update Jest to 26.x so that we can get better js-dom support.

I was adding document.createRange and createContextualFragment and I realized that our current version of Jest does not support those APIs. I saw on this issue that 26.x should now support those.

@wincent
Copy link
Contributor

wincent commented Nov 9, 2020

I think this is duplicate of #46 鈥斅爊ote that we have been holding off on the update due to still-existing performance regressions introduced in Jest v25. We actually did do an update at one point, although I don't have the link at hand, that was so bad that we had to roll it back (because the perf was so bad it made the tests time out).

@bryceosterhaus
Copy link
Member Author

@wincent yep you're right, didn't see that one. Thanks!

@jbalsas
Copy link
Contributor

jbalsas commented Nov 10, 2020

One option would be to simply mock createContextualFragment with exactly what metal-dom does in buildFragment.

That way we can start using it and jest will know how to handle until we update it.

@wincent
Copy link
Contributor

wincent commented Nov 12, 2020

One option would be to simply mock createContextualFragment with exactly what metal-dom does in buildFragment.

@bryceosterhaus did this in #234

I made a note in #46 reminding us to remove the mock once it's no longer needed.

wincent added a commit that referenced this issue Dec 18, 2020
docs: add bean, field and model documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants