Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom suffixes for resources files #273

Open
alexiscreuzot opened this issue Jun 11, 2016 · 3 comments
Open

Allow custom suffixes for resources files #273

alexiscreuzot opened this issue Jun 11, 2016 · 3 comments

Comments

@alexiscreuzot
Copy link

Current state

Currently, resources files are managed using this function :
https://github.com/thoughtbot/liftoff/blob/master/lib/liftoff/project_builder.rb#L90-L92

Problem

In some projects, the user might want to use custom templates files for resources, like .json, .txt or .yml files, without having to manually remove them from the "compile sources" build phase afterward.

Proposed solution

Adding an optional array to the liftoffrc file named additional_resources, used likeso :

additional_resources:
 - txt
 - json
 - yml

This array could then be added to the defaults suffixes in the project_builder.rb resource_file? function.

alexiscreuzot added a commit to alexiscreuzot/liftoff that referenced this issue Jun 13, 2016
@alexiscreuzot
Copy link
Author

Any update on my PR?

@gfontenot
Copy link
Member

hey @kirualex, really sorry for the radio silence. I'm being a poor maintainer. This PR made me start to think of some larger things and so I haven't had a chance to give it the attention I'd like. I'm going to try to go through it on Friday or some time next week. Thanks for your patience!

@Maximelc
Copy link

I use this method for custom extension #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants