Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobufjs 7.0.0 removes pbjs #398

Open
jroper opened this issue Aug 2, 2022 · 1 comment
Open

protobufjs 7.0.0 removes pbjs #398

jroper opened this issue Aug 2, 2022 · 1 comment
Labels
bug Something isn't working kalix-runtime Runtime and SDKs sub-team

Comments

@jroper
Copy link
Member

jroper commented Aug 2, 2022

We depend on pbjs for some things. protobufjs 7.0.0 has been released, and doesn't contain this, a new package, protobufjs-cli, contains it. I think our dependency on protobufjs is a minimum version so we may find users being automatically upgraded to this, and then protobuf compilation will break saying pbjs or pbts can't be found.

See protobufjs/protobuf.js#1773

@jroper jroper added bug Something isn't working kalix-runtime Runtime and SDKs sub-team labels Aug 2, 2022
@pvlugter
Copy link
Member

pvlugter commented Aug 5, 2022

Could be an opportunity to move the protobuf compilation to kalix-scripts, along with the other dev and codegen tooling. Will then be only a dev dependency on protobufjs-cli.

Good that a new version of protobufjs is finally out though, as it allows #326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

No branches or pull requests

2 participants