Related #5587 (comment) and also applies to #7094

Hi everyone! I will begin work on this issue @saubyk, @Roasbeef

Hi @alexbosworth! thanks for opening this issue. I did some research and I have some questions that will clarify things and help me move forward.

Instead, if a direct configuration is absent the node announcement settings could be persisted when set and used on restart

This means we should only persist the alias when it's not set in lnd.conf right? And does it make sense to persist Alias in the db and retrieve on restart or is there a better way to do so?

Additionally, should we persist the entire announcement settings (including Alias, Color, ...) if they're updated using the updatenodeannouncement RPC or just Alias.

What should happen is debatable I guess. Persistence is nice for people who want to control their LND from the API rather than from both the API and the conf file. Lack of persistence is nice for simplicity. Potentially there could be the best of both worlds with a mutable preferences file that gets updated with API changes but I think that might be out of scope

A potential option for the db mode is to follow what happens for channel opens that use the channel policy settings as an initial value however once a policy update call is initiated they write the results of that call to the database and override the conf setting permanently and don't pay attention to the conf setting going forward

Yes for sure any setting that is overridden on startup could be considered equally

Hi @alexbosworth, I opened PR #8690 for this issue. Would you mind taking a look and sharing your thoughts on whether I'm heading in the right direction? Any suggestions for improvement would be greatly appreciated!

Looks good to me, i guess the problem might become more of documentation to let people know that they are only setting an initial value in the conf, and you can't really go backwards right to where the conf is in control again

To be clear the order of checking for values when lnd starts up would be:
-1.) Check Lnd config, if empty go to step 2.
-2.)Check database, if empty go to step 3.
-3.) Let lnd create it.

Right?

hmm i didn't see that, ok but can i go back to total default, like remove both alias from conf and db? i guess the documentation aspect still stands

Yes documentation is important I am just trying to be clear on the proposed flow. So, If user did not specify a node announcement field such as alias in their lnd config file and the user had not called the UpdateNodeAnnouncement rpc in the previous uptime of the lnd client, then lnd can go ahead and use the default which is for alias, using the serialised public key to create it:

alias = hex.EncodeToString(serializedPubKey[:10])

So, I guess we can still go back to the default in this case. Just wanted to be clear if this is the flow we are going for.

To be clear the order of checking for values when lnd starts up would be:
-1.) Check Lnd config, if empty go to step 2.
-2.)Check database, if empty go to step 3.
-3.) Let lnd create it.

Right?

Yes, this is the intended flow. check lnd.conf, then db, and if all not set, then use default (which is the first 10 chars of node's pubkey)

Yes documentation is important I am just trying to be clear on the proposed flow. So, If user did not specify a node announcement field such as alias in their lnd config file and the user had not called the UpdateNodeAnnouncement rpc in the previous uptime of the lnd client, then lnd can go ahead and use the default which is for alias, using the serialised public key to create it:

alias = hex.EncodeToString(serializedPubKey[:10])

So, I guess we can still go back to the default in this case. Just wanted to be clear if this is the flow we are going for.

Yes, I guess we can still go back to the default by clearing what we saved initially in the db and not specifying the fields such as alias in the config file.

hmm i didn't see that, ok but can i go back to total default, like remove both alias from conf and db? i guess the documentation aspect still stands

Yes, going back to the default is possible.