Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Ping time is not accurate #8725

Open
alexbosworth opened this issue May 4, 2024 · 1 comment
Open

[bug]: Ping time is not accurate #8725

alexbosworth opened this issue May 4, 2024 · 1 comment
Labels
bug Unintended code behaviour needs triage P3 might get fixed, nice to have

Comments

@alexbosworth
Copy link
Contributor

Background

When calling ListPeers API, the list peer response returns an inaccurate ping time for a peer

Your environment

  • lnd 0.18.0-beta.rc1

Steps to reproduce

  • Add a peer

Expected behavior

  • The accurate peer ping time should be reflected

Actual behavior

  • Peer ping time is returned as '-1' which is not a possible time according to the rules of relativity
@alexbosworth alexbosworth added bug Unintended code behaviour needs triage labels May 4, 2024
@saubyk saubyk added the P3 might get fixed, nice to have label May 5, 2024
@bitromortac
Copy link
Collaborator

This is a default value for situations where a ping time wasn't measured:

99226e3#diff-1b1c0e1c6693b8d2fba799853f952e05a33461e8127c1b876a1d95a8f7da0c79R247-R256

Previously this would have been 0, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unintended code behaviour needs triage P3 might get fixed, nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexbosworth @bitromortac @saubyk