Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Allow for cancellation of EstimateRouteFee #8534

Open
hieblmi opened this issue Mar 8, 2024 · 0 comments · May be fixed by #8734
Open

[feature]: Allow for cancellation of EstimateRouteFee #8534

hieblmi opened this issue Mar 8, 2024 · 0 comments · May be fixed by #8734
Labels
enhancement Improvements to existing features / behaviour

Comments

@hieblmi
Copy link
Collaborator

hieblmi commented Mar 8, 2024 •
edited

This issue tracks a follow-up of the routing fee estimation overhaul in PR #8136.
The fee estimation api lacks the ability for users to aboard payment probes. Currently the payment probing only interrupts if the duration of a timeout parameter passed. But if the user interrupts the probing, the rpc call returns but the payment probing loop is left behind.

To achieve this the rpc context could be first passed in to SendPaymentV2 -> SendPaymentAsync -> sendPayment -> resumePayment, and then return here if the context was cancelled and after the last HTLC was resolved.
@hieblmi hieblmi added the enhancement Improvements to existing features / behaviour label Mar 8, 2024
@hieblmi hieblmi linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements to existing features / behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

routing: cancelable payment loop hieblmi/lnd
1 participant
@hieblmi