Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monolog from require-dev #135

Open
alexislefebvre opened this issue Jun 21, 2021 · 1 comment
Open

Remove monolog from require-dev #135

alexislefebvre opened this issue Jun 21, 2021 · 1 comment
Labels
enhancement New feature or request internal Updates that won't affect the API
Milestone

Comments

@alexislefebvre
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Monolog should not be mandatory to develop this bundle.

Describe the solution you'd like
Remove symfony/monolog-bridge and symfony/monolog-bundle from the requirements.

Use the NullLogger instead:

Describe alternatives you've considered
.

Additional context
.

@alexislefebvre alexislefebvre added this to the 2.x milestone Jun 28, 2021
@alexislefebvre
Copy link
Collaborator Author

alexislefebvre commented Jul 20, 2021

Removing monolog makes logs appear in the output of PHPUnit.

But there's a possible workaround: symfony/symfony#25676 (comment)

@alexislefebvre alexislefebvre added enhancement New feature or request internal Updates that won't affect the API labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal Updates that won't affect the API
Projects
None yet
Development

No branches or pull requests

1 participant