You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be good to refactor GrpcStatus and rename it to DefaultGrpcExceptionHandlerFunction. Afterward, DefaultGrpcExceptionHandlerFunction can be set to GrpcServiceBuilder and GrpcClientBuilder as default values.
Motivation:
- Closes#5550
Modifications:
- `GrpcStatus` implements `GrpcExceptionHandlerFunction`
- Rename `GrpcStatus` to `DefaultGrpcExceptionHandlerFunction`
Result:
- Closes#5550
- GrpcClientBuilder uses `DefaultGrpcExceptionHandlerFunction` as default
- GrpcService can use `DefaultGrpcExceptionHandlerFunction` for its `exceptionHandler`
<!--
Visit this URL to learn more about how to write a pull request description:
https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
Although we use
GrpcStatus
as the default implementation ofGrpcExceptionHandlerFunction
, it does not implementGrpcExceptionHandlerFunction
.armeria/grpc/src/main/java/com/linecorp/armeria/internal/common/grpc/GrpcStatus.java
Lines 79 to 80 in db3973d
It would be good to refactor
GrpcStatus
and rename it toDefaultGrpcExceptionHandlerFunction
. Afterward,DefaultGrpcExceptionHandlerFunction
can be set toGrpcServiceBuilder
andGrpcClientBuilder
as default values.armeria/grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcServiceBuilder.java
Line 118 in db3973d
armeria/grpc/src/main/java/com/linecorp/armeria/client/grpc/GrpcClientBuilder.java
Line 104 in db3973d
The text was updated successfully, but these errors were encountered: