Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemptively close the channel when receiving SslCloseCompletionEvent #5551

Open
yzfeng2020 opened this issue Apr 2, 2024 · 1 comment
Open

Comments

@yzfeng2020
Copy link
Contributor

Sometimes a server can throw the following exception io.netty.handler.ssl.SslClosedEngineException: SSLEngine closed already, - a remote peer can send a CLOSE_NOTIFY with its last SSL packet, which immediately closes the SSL engine. Armeria won't know about it until an attempt is made to send a message over that connection. Since the SSL engine is closed by that point, a SslClosedEngineException will be thrown. The right way to handle this is to preemptively close the engine.

@jrhee17
Copy link
Contributor

jrhee17 commented Apr 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants