Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider closing a request when the response is exceptionally completed #5563

Open
jrhee17 opened this issue Apr 3, 2024 · 0 comments
Open

Comments

@jrhee17
Copy link
Contributor

jrhee17 commented Apr 3, 2024

For certain protocols, we assume that the HttpRequest is hidden from the user well enough so we used a pooled buffer.

However, this may be prone to leaks if the request is never consumed.

@ikhoon has suggested that it may be more fail-proof to add a callback such that the request is aborted if response is exceptionally aborted.

ref: #5535 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant