Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-5578] make ContentTooLargeException extend HttpStatusException #5624

Closed
wants to merge 1 commit into from
Closed

[Issue-5578] make ContentTooLargeException extend HttpStatusException #5624

wants to merge 1 commit into from

Conversation

ChangguHan
Copy link
Contributor

Motivation:

Make ContentTooLargeException extend HttpStatusException
Issue #5578

Modifications:

  • Make HttpStatusException not final class
  • Make ContentTooLargeException extend HttpStatusException

Result:

@github-actions GitHub Actions
Copy link
Contributor

🔍 Build Scan® (commit: fed251a)

Job name Status Build Scan®
build-windows-latest-jdk-19 ✅ https://ge.armeria.dev/s/5i5n3np6fw7mu
build-self-hosted-unsafe-jdk-8 ✅ https://ge.armeria.dev/s/hkbth4b4gxngy
build-self-hosted-unsafe-jdk-19-snapshot-blockhound ✅ https://ge.armeria.dev/s/r44ou3tpcod5g
build-self-hosted-unsafe-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/ztegjfbtpxlgs
build-self-hosted-unsafe-jdk-17-min-java-11 ❌ (failure) https://ge.armeria.dev/s/m7coyofw76bks
build-self-hosted-unsafe-jdk-17-leak ✅ https://ge.armeria.dev/s/hotpo6zwjxcig
build-self-hosted-unsafe-jdk-11 ✅ https://ge.armeria.dev/s/6piiwyskgg4v4
build-macos-12-jdk-19 ✅ https://ge.armeria.dev/s/av5572org3li4

@ikhoon
Copy link
Contributor

ikhoon commented Apr 22, 2024

I realized that ContentTooLargeException can't simply extend HttpStatusException because HttpStatusException is in server package but ContentTooLargeException is in common.

I think my first idea was wrong, sorry. This issue should be considered in Armeria 2.0. Would you mind closing this PR and looking at other issues?

@ChangguHan
Copy link
Contributor Author

@ikhoon
No problem. Thank you 👍

@ChangguHan ChangguHan closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikhoon ikhoon Awaiting requested review from ikhoon ikhoon is a code owner

@jrhee17 jrhee17 Awaiting requested review from jrhee17 jrhee17 is a code owner

@minwoox minwoox Awaiting requested review from minwoox minwoox is a code owner

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider making ContentTooLargeException extend HttpStatusException
2 participants
@ChangguHan @ikhoon