Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make defaultUseHttp2Preface flag more explicit #5641

Open
ikhoon opened this issue Apr 26, 2024 · 0 comments
Open

Make defaultUseHttp2Preface flag more explicit #5641

ikhoon opened this issue Apr 26, 2024 · 0 comments

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Apr 26, 2024

defaultUseHttp2Preface has only true and false options and does not tell which protocols HTTP/2 connection preface should be used for. Currently, the option is applied to both http and h2c. It is not supported to apply either http or h2c.

If we improve defaultUseHttp2Preface and allow users to specify protocols, it would be helpful to troubleshoot various network issues.

Proposal:

  • Syntax: defaultUseHttp2Preface=string|array
  • Example
    • defaultUseHttp2Preface=all
      • Always use HTTP/2 even for h1c. This option may be used to diagnose network issues.
      • Generally, it is not recommended.
    • defaultUseHttp2Preface=http,h2c
      • Use connection preface for HTTP and H2C
      • This value can be the sensible default.
    • defaultUseHttp2Preface=h2c
      • Connection preface is only used for H2C.
      • This would be a good option if you have to communicate with legacy servers that do not understand HTTP/2 upgrade requests.
    • defaultUseHttp2Preface=none
      • Always use an upgrade request
  • Backward compatibility
    • defaultUseHttp2Preface=true
      • true means http,h2c
    • defaultUseHttp2Preface=false
      • false means none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant