Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pendingResponses to ServerMetrics #5666

Open
minwoox opened this issue May 8, 2024 · 0 comments
Open

Add pendingResponses to ServerMetrics #5666

minwoox opened this issue May 8, 2024 · 0 comments

Comments

@minwoox
Copy link
Member

minwoox commented May 8, 2024

Currently, pendingResponses are managed in GracefulShutdownSupport. It would be beneficial to manage all server-related metrics within ServerMetrics, which will be added in #5627.

meterRegistry.gauge("armeria.server.pending.responses", gracefulShutdownSupport,
GracefulShutdownSupport::pendingResponses);

Side note: the difference between activeRequests and pendingResponses is that the pendingResponses does not include the request count for transient services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant