Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set User Handle to a salted hash or random #21

Open
seachicken opened this issue Nov 27, 2021 · 2 comments
Open

Set User Handle to a salted hash or random #21

seachicken opened this issue Nov 27, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@seachicken
Copy link
Member

The current User Handle (a.k.a user ID) is a hash of the user name.

byte[] digest = Digests.sha256(username.getBytes(StandardCharsets.UTF_8));

The documentation appears to recommend it with salted hash or random, so should we change that?

This includes hash values of personally identifying information, unless the hash function is salted with salt values private to the Relying Party, since hashing does not prevent probing for guessable input values. It is RECOMMENDED to let the user handle be 64 random bytes, and store this value in the user’s account.

https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#sctn-user-handle-privacy

@kj84park
Copy link
Member

kj84park commented Nov 27, 2021

Yes, you are right.
Thank you for your opinion.

I think it would be better to provide a random value:slightly_smiling_face:

@kj84park kj84park added the enhancement New feature or request label Nov 27, 2021
@kj84park
Copy link
Member

Yes, you are right. Thank you for your opinion.

I think it would be better to provide a random value🙂

I realized that there might be a lot of parts that need to be fixed to provide random values.

I think we might have to find another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants