how can I put a literal curly-brace in the message

[ninesunsabiu]

I have a text like this: tip: use {var} in your comment, then...
I want to directly display the { and } symbols to the user, but after extract they are recognized as a variable.

I've tried adding ' but it doesn't seem perfect.

I referred to the method on https://wiki.zimbra.com/wiki/Translations.

[andrii-bodnar]

It should work with escaping with the ' character (reference - #1075)

Test case:

js-lingui/packages/core/src/interpolate.test.ts

Lines 34 to 38 in f15ce15

	it("should not interpolate escaped placeholder", () => {
	const msg = prepare("Hey '{name}'!")
	expect(msg({ name: "Joe" })).toEqual("Hey {name}!")
	})

[thekip]

Well, i see the bug. The message gets double compiled in dev mode and curly braces got processed second time.

and I notice the ' character is missing

That is expected. It's compiled to a string. When there is interpolation there would be an array with 3 entries, instead one string. This an internal lingui catalog representation.

[ninesunsabiu]

Why message should compile in dev mode ? Is it for handling scenarios like t({ message: 'something {theVar}', id: 'abcd' }) that haven't been extracted in development mode?

change the code to

-    let translation = messageForId || message || id

+    let translation = messageForId || (() => {
+        return process.env.NODE_ENV !== "production" && isString(message) ? compileMessage(message) : undefined
+    })() || id
 
-    if (process.env.NODE_ENV !== "production") {
-      translation = isString(translation)
-        ? compileMessage(translation)
-        : translation
-    }

only compile options#message in dev mode.

Will this change solve the problem?

@thekip

[thekip]

Yes, that's exactly how i wanted to solve this issue. You need to bypass compilation for messageForId but still compile message || id. But this change should also be covered by tests and i also could not predict how it can affect other users (what about if some loading not compiled catalogs during dev? This could break the flow for them, even though it's a misuse of a lib)

[ninesunsabiu]

I tried modifying it according to the above method. Unfortunately, I found that many test cases in the unit tests rely on the behavior of compiling messageForId.

for example:

js-lingui/packages/core/src/i18n.test.ts

Lines 189 to 203 in 69c1c23

	it("._ should format message from catalog", () => {
	const messages = {
	Hello: "Salut",
	"My name is {name}": "Je m'appelle {name}",
	}
	const i18n = setupI18n({
	locale: "fr",
	messages: { fr: messages },
	})
	expect(i18n._("Hello")).toEqual("Salut")
	expect(i18n._("My name is {name}", { name: "Fred" })).toEqual(
	"Je m'appelle Fred"
	)

in real word, the value of messages#['My name is {name}'] is ["Je m'appelle ",["name"]] (compile from po file by cli)

should I change these test case ?

[thekip]

Yes, it's better to change to the compiled strings. You also can change the ID to something short to avoid misunderstanding in the tests:

 "user.name": ["Je m'appelle ",["name"]], 

[thekip]

i created an issue #1901

[ninesunsabiu]

thx~