fix: param name for missing in setupI18nProps

[taozhou-glean]

Description

setupI18nProps.missing will be called with first param as the locale if its a function, but the type states message which is a bit misleading. I also updated the wording in the doc to also use locale to be consistent and more accurate.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Fixes # (issue)

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works

param name change in type and doc change only

• I have added necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 8, 2023 at 5:37PM (UTC)

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/esm/index.js	1.76 KB (0%)
./packages/detect-locale/build/esm/index.js	812 B (0%)
./packages/react/build/esm/index.js	1.79 KB (0%)
./packages/remote-loader/build/esm/index.js	7.29 KB (0%)

[codecov]

Codecov Report

Base: 69.62% // Head: 69.62% // No change to project coverage 👍

Coverage data is based on head (57a3787) compared to base (8bc212d).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1411   +/-   ##
=======================================
  Coverage   69.62%   69.62%           
=======================================
  Files          72       72           
  Lines        2143     2143           
  Branches      581      581           
=======================================
  Hits         1492     1492           
  Misses        516      516           
  Partials      135      135           

Impacted Files	Coverage Δ
packages/core/src/i18n.ts	68.75% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Martin005]

@taozhou-glean Please update also the line 74 in packages/core/src/i18n.ts, thanks!

[taozhou-glean]

@taozhou-glean Please update also the line 74 in packages/core/src/i18n.ts, thanks!

Done!

[taozhou-glean]

Thanks! somehow the code coverage check was failing, just rebased with upstream to let it rerun, is there a quick way to re-run a failed check ?

[Martin005]

@taozhou-glean The code coverage is currently broken and we are working on fixing it. No need to worry about it 🙂

[taozhou-glean]

@taozhou-glean The code coverage is currently broken and we are working on fixing it. No need to worry about it 🙂

ah i see, is there anything else I need to merge this ? the Merge button is disabled for me: You’re not [authorized](https://docs.github.com/articles/about-protected-branches/) to merge this pull request. @Martin005

[taozhou-glean]

@andrii-bodnar thanks! Would you mind merging this since I can't ;)

[andrii-bodnar]

@taozhou-glean waiting for @Martin005's review and the PR will be merged 🙂