Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): remove deprecated defaultProps from Trans cmp #1494

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Mar 9, 2023

fix #1493

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 4:31PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.87 ⚠️

Comparison is base (afd6513) 73.31% compared to head (3260110) 69.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   73.31%   69.44%   -3.87%     
==========================================
  Files          83       72      -11     
  Lines        3219     2147    -1072     
  Branches      956      584     -372     
==========================================
- Hits         2360     1491     -869     
+ Misses        669      521     -148     
+ Partials      190      135      -55     
Impacted Files Coverage Δ
packages/react/src/Trans.tsx 80.00% <100.00%> (+2.22%) ⬆️
packages/cli/src/api/help.ts 10.00% <0.00%> (-43.85%) ⬇️
packages/cli/src/lingui-extract-template.ts 0.00% <0.00%> (-42.43%) ⬇️
packages/cli/src/api/extractors/babel.ts 54.54% <0.00%> (-29.24%) ⬇️
packages/cli/src/api/stats.ts 70.00% <0.00%> (-16.67%) ⬇️
packages/remote-loader/src/browserCompiler.ts 40.00% <0.00%> (-14.55%) ⬇️
packages/cli/src/lingui-extract.ts 0.00% <0.00%> (-12.77%) ⬇️
packages/cli/src/api/extractors/index.ts 57.89% <0.00%> (-8.78%) ⬇️
packages/remote-loader/src/index.ts 71.42% <0.00%> (-7.52%) ⬇️
packages/macro/src/index.ts 83.87% <0.00%> (-6.86%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar
Copy link
Contributor

@thekip main branch?

@thekip
Copy link
Collaborator Author

thekip commented Mar 10, 2023

Yes

@andrii-bodnar andrii-bodnar merged commit aff6d67 into lingui:main Mar 10, 2023
@thekip thekip deleted the fix-1493 branch March 10, 2023 08:27
andrii-bodnar added a commit that referenced this pull request Mar 14, 2023
fix(react): remove deprecated defaultProps from Trans cmp (#1494)
andrii-bodnar added a commit that referenced this pull request Mar 24, 2023
docs(vite-setup): add missing dependencies and show ts configuration (#1556)
Update lingui import statement in setup-vite.md (#1552)
fix(react): remove deprecated defaultProps from Trans cmp (#1494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trans: Support for defaultProps will be removed from function components in a future major release
3 participants