Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macro): support tagged templates in defineMessage + short alias #1495

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Mar 9, 2023

Description

import {defineMessage, msg} from "@lingui/macro"
const msg = defineMessage`Refresh inbox`

// or alias
const msg = msg`Refresh inbox`

Rust Version is coming soon (probably by the end of today)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 7:33PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.56 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.25 KB (0%)

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (3ae3c1e) 73.90% compared to head (4ea55e6) 73.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1495      +/-   ##
==========================================
+ Coverage   73.90%   73.93%   +0.02%     
==========================================
  Files          67       67              
  Lines        1870     1872       +2     
  Branches      489      493       +4     
==========================================
+ Hits         1382     1384       +2     
  Misses        383      383              
  Partials      105      105              
Impacted Files Coverage Δ
packages/macro/src/index.ts 96.29% <ø> (ø)
packages/macro/test/js-defineMessage.ts 100.00% <ø> (ø)
packages/macro/test/js-t.ts 100.00% <ø> (ø)
packages/macro/src/macroJs.ts 96.66% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit ec95916 into lingui:next Mar 10, 2023
@thekip thekip deleted the feature/extended-define-message branch March 10, 2023 09:13
@thekip
Copy link
Collaborator Author

thekip commented Mar 10, 2023

SWC Version: lingui/swc-plugin#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants