fix(macro types): mark other as required for ChoiceOptions

[taozhou-glean]

Description

other should be required for choice macros, and looks like we do have it as required for SelectOptions, SelectChoiceProps and PluralChoiceProps, just not ChoiceOptions which is probably not intended.

and ICU message without other may be invalid:

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Fixes # (issue)

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 16, 2023 at 5:53PM (UTC)

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/esm/index.js	1.57 KB (0%)
./packages/detect-locale/build/esm/index.js	812 B (0%)
./packages/react/build/esm/index.js	1.67 KB (0%)
./packages/remote-loader/build/esm/index.js	7.25 KB (0%)

[thekip]

You need also add a test in packages/macro/__typetests__/index.test-d.tsx

[taozhou-glean]

You need also add a test in packages/macro/__typetests__/index.test-d.tsx

done! thanks

[taozhou-glean]

You need also add a test in packages/macro/__typetests__/index.test-d.tsx

done! thanks

BTW, yarn test:tsd is failing with 3 tests on t({}) above for me, checked upstream/next and same there. @thekip

[thekip]

yarn release:build before yarn test:tsd it's a known issue, building modern application with monorepo is hard.

I'm currently looking for another solution.

[taozhou-glean]

yarn release:build before yarn test:tsd

test all passed now! maybe just update scripts for test:tsd to always run release:build before as a workaround for now

[thekip]

in github WF it's already done this way. In development, it doesn't bother me so much. And i actually find it more useful to have faster feedback when working on typings, so i'm running build once and then re-run only tests.