feat(config): show more clear error message when config is not found #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thekip
commented
Apr 19, 2023
Comment on lines
+23
to
+44
| const moduleName = "lingui" | ||
|
|
||
| const configExplorer = cosmiconfigSync(moduleName, { | ||
| searchPlaces: [ | ||
| `${moduleName}.config.js`, | ||
| `${moduleName}.config.cjs`, | ||
| `${moduleName}.config.ts`, | ||
| `${moduleName}.config.mjs`, | ||
| "package.json", | ||
| `.${moduleName}rc`, | ||
| `.${moduleName}rc.json`, | ||
| `.${moduleName}rc.yaml`, | ||
| `.${moduleName}rc.yml`, | ||
| `.${moduleName}rc.ts`, | ||
| `.${moduleName}rc.js`, | ||
| ], | ||
| loaders: { | ||
| ".js": JitiLoader(), | ||
| ".ts": JitiLoader(), | ||
| ".mjs": JitiLoader(), | ||
| }, | ||
| }) |
There was a problem hiding this comment.
i read in the cosmiconfig docs that hey have a cache on the configExplorer instacne. Pulling creating this explorer out of the getConfig function should help to leverage this cache.
size-limit report 📦
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1606 +/- ##
==========================================
+ Coverage 75.40% 75.45% +0.04%
==========================================
Files 77 77
Lines 1988 1992 +4
Branches 519 520 +1
==========================================
+ Hits 1499 1503 +4
Misses 375 375
Partials 114 114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discord conversation: https://discord.com/channels/974702239358783608/1088763465960787998/1089890861992661012
Currently, when lingui could not discover a config it just shows
No locales defined, which is pretty confusing.This PR brings "Config not found" error message.
Types of changes
Fixes # (issue)
Checklist