fix(vue-extractor): support components with no <template> #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Touffy
force-pushed
the
vue-extractor-fix
branch
from
61db6cb
to
3564f5f
Compare
7 tasks
thekip
reviewed
Apr 27, 2023
Touffy
force-pushed
the
vue-extractor-fix
branch
from
3564f5f
to
18c8435
Compare
Touffy
changed the title
thekip
approved these changes
Apr 27, 2023
andrii-bodnar
approved these changes
Apr 27, 2023
|
Fixed issue with |
|
@Touffy you have issue with prettier |
|
@Touffy thanks for the contribution! It seems like there are some Prettier issues in the code. Could you please take a look? |
Touffy
force-pushed
the
vue-extractor-fix
branch
from
18c8435
to
ba24a1b
Compare
|
Sorry. Fixed. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
==========================================
+ Coverage 75.40% 75.46% +0.06%
==========================================
Files 77 77
Lines 1988 1989 +1
Branches 519 518 -1
==========================================
+ Hits 1499 1501 +2
+ Misses 375 374 -1
Partials 114 114
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An improvement to the recently merged Vue single-file component extractor : A SFC may have no
<template>(functional components), in which case the extract should just move on with the script.Types of changes
Checklist