Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format-po): configure header attributes in PO file formatter #1934

Merged
merged 2 commits into from
May 14, 2024

Conversation

mariarchy
Copy link
Contributor

Description

Support adding custom header attributes to the PO message catalog via the PO formatter config

This is particularly useful for localization tools that require custom PO file headers. For instance, CrowdIn requires the addition of a custom header attribute to enable a specific PO file parsing setting (more here)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Sorry, something went wrong.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 9:20am

Copy link

github-actions bot commented May 13, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.87 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@timofei-iatsenko timofei-iatsenko self-requested a review May 14, 2024 07:01
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contribution.

There is an issue with a prettier, you probably didn't format code using it.

@timofei-iatsenko
Copy link
Collaborator

Please also update a readme file for this package.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (d6b9698) to head (afeae4a).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   76.65%   76.03%   -0.63%     
==========================================
  Files          81       85       +4     
  Lines        2090     2111      +21     
  Branches      533      540       +7     
==========================================
+ Hits         1602     1605       +3     
- Misses        375      393      +18     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariarchy
Copy link
Contributor Author

done! thanks for the prompt review @thekip

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariarchy thanks for the contribution!

@andrii-bodnar andrii-bodnar merged commit d90f778 into lingui:main May 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants