-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(format-po): configure header attributes in PO file formatter #1934
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for contribution.
There is an issue with a prettier, you probably didn't format code using it.
Please also update a readme file for this package. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 76.65% 76.03% -0.63%
==========================================
Files 81 85 +4
Lines 2090 2111 +21
Branches 533 540 +7
==========================================
+ Hits 1602 1605 +3
- Misses 375 393 +18
Partials 113 113 ☔ View full report in Codecov by Sentry. |
done! thanks for the prompt review @thekip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariarchy thanks for the contribution!
Description
Support adding custom header attributes to the PO message catalog via the PO formatter config
This is particularly useful for localization tools that require custom PO file headers. For instance, CrowdIn requires the addition of a custom header attribute to enable a specific PO file parsing setting (more here)
Types of changes
Checklist