Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more Utility Functions from MediaTransformer #238

Open
timcreatedit opened this issue Jan 9, 2023 · 1 comment
Open

Expose more Utility Functions from MediaTransformer #238

timcreatedit opened this issue Jan 9, 2023 · 1 comment

Comments

@timcreatedit
Copy link

timcreatedit commented Jan 9, 2023

MediaTransformer does a really nice job of being very simple to use when you're first getting started.
Once you want advanced functionality however, you are faced with creating your own MediaTarget, MediaFormat, TrackTransforms etc.

There's a lot of nice logic in LiTr that has been written to do exactly that, but a lot of it is private, even if it doesn't have any side effects. When building my own more custom transformer, I found myself copying logic from MediaTransformer (createTargetMediaFormat, isAudioIncompatible, ...) constantly.

I think there is a big opportunity to make LiTr more approachable by exposing more of the Utility that is hidden away inside. Dealing with MediaFormats is both a daunting task for beginners, but also very essential in a lot of cases, so I assume a lot of users would benefit from improving the usability in that regard :)

A first step would be opening up some of the functions that are already there, but on top of that, more utility functions could still be written

@izzytwosheds
Copy link
Contributor

This is an excellent suggestion! I have been thinking about writing some helper methods for MediaFormat creation - things like typical resolutions/aspect ratios, etc. But I didn't think about exposing some internal util methods. Any specific functionality you would want to see exposed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants