Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new InlineMockMaker interface in Mockito 2.25.0 #137

Closed
ttanxu opened this issue Mar 11, 2019 · 0 comments · Fixed by #138
Closed

Implement new InlineMockMaker interface in Mockito 2.25.0 #137

ttanxu opened this issue Mar 11, 2019 · 0 comments · Fixed by #138

Comments

@ttanxu
Copy link
Contributor

ttanxu commented Mar 11, 2019

Mockito introduced InlineMockMaker interface to solve memory leaks caused by inline mocking in PR. Need to implement that interface to make that work for InlineDexmakerMockMaker.
ttanxu added a commit to ttanxu/dexmaker that referenced this issue Mar 11, 2019
@ttanxu
Update to Mockito 2.25.0 and impl InlineMockMaker.
4c414d9 
In certain specific, rare cases inline mocking causes memory leaks.
Mockito introduced a new API to explicitly clear mock state in version
2.25.0. To make that work we need to implement the new InlineMockMaker
interface, hence I make this pull request.

This fixes linkedin#137.
@ttanxu ttanxu mentioned this issue Mar 11, 2019
Merged
drewhannay pushed a commit that referenced this issue Mar 12, 2019
@ttanxu @drewhannay
Update to Mockito 2.25.0 and impl InlineMockMaker.
9cee741 
In certain specific, rare cases inline mocking causes memory leaks.
Mockito introduced a new API to explicitly clear mock state in version
2.25.0. To make that work we need to implement the new InlineMockMaker
interface, hence I make this pull request.

This fixes #137.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Mockito 2.25.0 and implement InlineMockMaker. ttanxu/dexmaker
1 participant
@ttanxu