Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow pass-through Kafka config in samza VeniceSystemProducer #653

Open
1 of 10 tasks
ZacAttack opened this issue Sep 21, 2023 · 0 comments
Open
1 of 10 tasks
Labels
enhancement New feature or request

Comments

@ZacAttack
Copy link
Contributor

ZacAttack commented Sep 21, 2023

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

Feature Request Proposal

Currently, the Kafka producer config in VeniceWriter being used by Samza VeniceSystemProducer is not tunable since Kafka config pass through is not supported.

Motivation

What is the use case for this feature?

Enabling pass through of configs would enable us to keep up with new tunable parameters we'd like to adopt into the producer. As it stands today, we have to cut code in order to add new parameters. So it'd be ideal to club all future N birds with this stone.

Details

No response

What component(s) does this bug affect?

  • Controller: This is the control-plane for Venice. Used to create/update/query stores and their metadata.
  • Router: This is the stateless query-routing layer for serving read requests.
  • Server: This is the component that persists all the store data.
  • VenicePushJob: This is the component that pushes derived data from Hadoop to Venice backend.
  • VenicePulsarSink: This is a Sink connector for Apache Pulsar that pushes data from Pulsar into Venice.
  • Thin Client: This is a stateless client users use to query Venice Router for reading store data.
  • Fast Client: This is a stateful client users use to query Venice Server for reading store data.
  • Da Vinci Client: This is an embedded, stateful client that materializes store data locally.
  • Samza: This is the library users use to make nearline updates to store data.
  • Admin Tool: This is the stand-alone client used for ad-hoc operations on Venice.
@ZacAttack ZacAttack added the enhancement New feature or request label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant