Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure timetableBackup is properly shutdown #58

Open
narendly opened this issue Dec 17, 2021 · 0 comments
Open

Ensure timetableBackup is properly shutdown #58

narendly opened this issue Dec 17, 2021 · 0 comments

Comments

@narendly
Copy link

narendly commented Dec 17, 2021

b95f9e1#diff-c4c4d2dfc4872704464b23f5c7d876479444b2f393b60c4ebe5fb182b645cf00R196-R202

Here it synchronizes on the class reference, but this should synchronize on this for proper shutdown of the timetable backup thread. This is because notifyAll() is called on the object instance of TimetableBackup, not the static class reference itself.

-> UPDATE: (20MAY22), TimetableBackup.this is correct. The shutdown method is missing though (see below)

Also, BackupManager::stop() is missing timetableBackup.shutdown();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant