Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish shell completions #4208

Closed
nesl247 opened this issue Mar 27, 2020 · 6 comments · Fixed by #4751
Closed

Add fish shell completions #4208

nesl247 opened this issue Mar 27, 2020 · 6 comments · Fixed by #4751

Comments

@nesl247
Copy link

nesl247 commented Mar 27, 2020

Feature Request

Add fish shell completions. Currently only bash/zsh are supported.

What problem are you trying to solve?

Adding completions to the very popular fish shell

How should the problem be solved?

Add support for linkerd completion fish.

@grampelberg
Copy link
Contributor

Blocked on spf13/cobra#754

@grampelberg grampelberg added this to To do in Help Wanted via automation Mar 27, 2020
@nesl247
Copy link
Author

nesl247 commented Mar 27, 2020

Or this one which seems like it has a better chance of being merged: spf13/cobra#1048 instead

@nesl247
Copy link
Author

nesl247 commented Apr 13, 2020

The PR was merged. Any chance we could get cobra updated for the next release?

@grampelberg
Copy link
Contributor

@nesl247 sure! Up for a PR? I suspect @adleong will particularly appreciate it =)

@nesl247
Copy link
Author

nesl247 commented Apr 13, 2020

I'll try to tackle it when I can. I tried to get it to work earlier, but the completions it generated weren't actually working. If someone wants to pick it up from where I left off (let me know and I can submit a PR or something), great, otherwise I'll get to it when I can.

@WLun001
Copy link
Contributor

WLun001 commented Jul 11, 2020

I can take this task

WLun001 added a commit to WLun001/linkerd2 that referenced this issue Jul 11, 2020
WLun001 added a commit to WLun001/linkerd2 that referenced this issue Jul 11, 2020
fixes linkerd#4208

Signed-off-by: Wei Lun <weilun_95@hotmail.com>
Help Wanted automation moved this from To do to Done Jul 20, 2020
adleong pushed a commit that referenced this issue Jul 20, 2020
fixes #4208

Signed-off-by: Wei Lun <weilun_95@hotmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Help Wanted
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants