Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compacting during normal operation (don't early exit) #477

Open
kellyselden opened this issue Mar 17, 2023 · 2 comments
Open

Allow compacting during normal operation (don't early exit) #477

kellyselden opened this issue Mar 17, 2023 · 2 comments

Comments

@kellyselden
Copy link

kellyselden commented Mar 17, 2023

Here is my pseudocode:

const { compactTodoStorageFile } = require('@lint-todo/utils');

try {
  compactTodoStorageFile();
} catch {
  write empty .lint-todo
}

INCLUDE_TODO=1 eslint with junit

output junit for dirty .lint-todo's

While this works (thanks for compactTodoStorageFile by the way!), it would be nice if I could do:

INCLUDE_TODO=1 COMPACT_TODO=1 eslint with junit

output junit for dirty .lint-todo's

But since COMPACT_TODO is an early exit, it has to be a two step process. The workaround works fine if you want to close this. Thanks!

@scalvert
Copy link
Collaborator

This seems reasonable. The idea was to really minimize the work done via the actual linting process.

I'll put some thought into the potential impact of this.

@Alonski
Copy link

Alonski commented Nov 15, 2023

Hey
Wondering if there was ever any thoughts on this and potential work that was done. Would love to see this done.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants