Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML in plain text emails #5417

Open
xi opened this issue Jan 25, 2024 · 1 comment
Open

HTML in plain text emails #5417

xi opened this issue Jan 25, 2024 · 1 comment
Labels
Prio: Low fix when there is time Type: Bug incorrect or uexpected behaviour

Comments

@xi
Copy link
Contributor

xi commented Jan 25, 2024

I just received an email to confirm my mail address. It contained HTML in the plain text part:

<p>
bitte bestätigen Sie Ihre E-Mail-Adresse um Ihr Konto auf mein.berlin.de freizuschalten.
</p>
<p>
Nach der Bestätigung können Sie Ideen und Kommentare anlegen und bewerten und an Umfragen teilnehmen.
</p>
<p>
Bei Fragen können Sie sich an support@mein.berlin.de wenden.
</p>

I tried to dig into the code to see why this happens. It seems like most email templates overwrite {% block content %} which is used in both email_base.html and email_base.txt. The proper solution is probably to only use plain text inside {% block content %}, and additionally also overwrite {% block content_html %} if HTML is desired.

@goapunk goapunk added the Type: Bug incorrect or uexpected behaviour label Jan 29, 2024
@goapunk
Copy link
Contributor

goapunk commented Jan 29, 2024

hi @xi,
thanks for the issue and the research. We'll discuss it and hopefully come up with a fix soon.

cc @CarolingerSeilchenspringer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Low fix when there is time Type: Bug incorrect or uexpected behaviour
Projects
None yet
Development

No branches or pull requests

3 participants