Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No arrow on dropdown select in community debat and possible elsewhere? #2470

Open
philli-m opened this issue Mar 10, 2022 · 2 comments
Open

Comments

@philli-m
Copy link
Contributor

https://opin-dev.liqd.net/en/communitydebate/create/module/community-debate-9/
expected behaviour: arrow to show user it is a select element
behaviour: no arrow is displayed

@philli-m
Copy link
Contributor Author

NOTE: We use select-dropdown here (https://github.com/liqd/adhocracy4/blob/a2b1d36e7beb30b08fbf609f92761479a60dff4b/adhocracy4/static/select_dropdown.js) instead of select2 which we use in our other apps
We should look into unifying our select elements to use 1 but not sure which is the better choice at this time, @khamui @fuzzylogic2000 any thoughts on this?

@khamui
Copy link
Contributor

khamui commented Mar 14, 2022

@phillimorland without looking deeper into code i would think its better to use our select-dropdown and plan a rewrite of it with vanilla js (to get rid of jQuery). But i am not sure if select2 brings something, that select-dropdown can't provide currently? Do you know if they are interchangeable?

depending on what we need from a select-component we could research for one that already brings what we need, but is written in plain js?

in any case it will bring bit of work and especially testing with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants