Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash in liquibase.hub.url returns confusing error. #1309

Merged
merged 4 commits into from
Aug 14, 2020

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Aug 7, 2020

DAT-5072


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

Copy link
Contributor

@wwillard7800 wwillard7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #1309 into DAT-4800 will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             DAT-4800    #1309      +/-   ##
==============================================
+ Coverage       49.14%   49.16%   +0.01%     
- Complexity       7669     7675       +6     
==============================================
  Files             750      750              
  Lines           36369    36377       +8     
  Branches         6579     6580       +1     
==============================================
+ Hits            17874    17884      +10     
+ Misses          16129    16128       -1     
+ Partials         2366     2365       -1     
Impacted Files Coverage Δ Complexity Δ
...liquibase/configuration/ConfigurationProperty.java 59.42% <100.00%> (+4.03%) 21.00 <5.00> (+3.00)
...java/liquibase/configuration/HubConfiguration.java 73.17% <100.00%> (+2.90%) 11.00 <2.00> (+2.00)
...e/src/main/java/liquibase/util/DependencyUtil.java 91.15% <0.00%> (-0.89%) 0.00% <0.00%> (ø%)
...-core/src/main/java/liquibase/util/ObjectUtil.java 37.98% <0.00%> (+1.11%) 36.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aedc079...58de785. Read the comment docs.

@nvoxland nvoxland merged commit 0791f18 into DAT-4800 Aug 14, 2020
@nvoxland nvoxland deleted the DAT-5072 branch August 14, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants