Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1438 - changeset dbms field serialization #1450

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

p1729
Copy link
Contributor

@p1729 p1729 commented Oct 2, 2020

Fixes #1438


name: Pull Request
about: Fix changeset dbms field serialisation
title: Fix changeset dbms field serialisation
labels: Status:Fixed
assignees: ''


Environment

Liquibase Version: 4.1.1-local-SNAPSHOT

Liquibase Integration & Version: CLI

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version: MacOS 10.15.6

Pull Request Type

  • [x ] Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Serialisation of multiple dbms values in changeset is not happening correctly

Steps To Reproduce

Create a changeset with multiple dbms e.g 'dbms1, dbms2' and ask for serialisation of dbms field

Actual Behavior

Serialisation of multiple dbms adds ',xxx' between multiple dbms serialised value

Expected/Desired Behavior

Serialisation of multiple dbms add ',' between multiple dbms serialised value

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #1450 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1450   +/-   ##
=========================================
  Coverage     47.80%   47.80%           
+ Complexity     7844     7843    -1     
=========================================
  Files           792      792           
  Lines         38516    38516           
  Branches       6880     6880           
=========================================
  Hits          18413    18413           
  Misses        17674    17674           
  Partials       2429     2429           
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/liquibase/changelog/ChangeSet.java 64.16% <100.00%> (ø) 154.00 <0.00> (ø)
...re/src/main/java/liquibase/util/ISODateFormat.java 78.68% <0.00%> (-1.64%) 16.00% <0.00%> (-1.00%)
...e/src/main/java/liquibase/util/DependencyUtil.java 92.10% <0.00%> (+0.87%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f71ff...27eb6e7. Read the comment docs.

@p1729 p1729 changed the title Fix changeset dbms field serialization issue#1438 Fix #1438 - changeset dbms field serialization Oct 3, 2020
@molivasdat molivasdat added DBAll hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs IntegrationCLI RiskMedium Changes that require more testing or that affect many different code paths. Severity3 TypeBug labels Oct 6, 2020
@molivasdat
Copy link
Contributor

Congrats @p1729 Hacktoberfest accepted. Thanks for your contribution!

@nvoxland
Copy link
Contributor

nvoxland commented Nov 3, 2020

Thanks!

Cherry picked into 4.2.x as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBAll hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs IntegrationCLI RiskMedium Changes that require more testing or that affect many different code paths. Severity3 TypeBug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML Export adds ',xxx' instead of ','
4 participants