Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UniqueConstraintSnapshotGenerator #1548

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Fixed UniqueConstraintSnapshotGenerator #1548

merged 2 commits into from
Nov 24, 2020

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Nov 18, 2020

Reverted a previous commit that assumed all databases support bulk-querying constraint columns. Then, incorporated changes from #1479 to increase the number of databases that do support them.

Fixes #1477

Copy link
Contributor

@wwillard7800 wwillard7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #1548 (4efdc0e) into 4.2.x (05257e8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              4.2.x    #1548   +/-   ##
=========================================
  Coverage     49.59%   49.59%           
- Complexity     7862     7863    +1     
=========================================
  Files           757      757           
  Lines         37024    37025    +1     
  Branches       6699     6696    -3     
=========================================
+ Hits          18362    18364    +2     
  Misses        16232    16232           
+ Partials       2430     2429    -1     
Impacted Files Coverage Δ Complexity Δ
...napshot/jvm/UniqueConstraintSnapshotGenerator.java 5.55% <0.00%> (-0.03%) 4.00 <0.00> (ø)
...-core/src/main/java/liquibase/util/ObjectUtil.java 37.98% <0.00%> (+1.11%) 36.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05257e8...4efdc0e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants