Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty change with self closing tag DAT-5699 #1557

Closed
wants to merge 25 commits into from
Closed

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Nov 23, 2020


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

wwillard7800 and others added 18 commits September 25, 2020 09:37
There is no need to force callers to handle Exception.
The implementation of the close method can currently throw only a DatabaseException. But since the library has a parent exception class - LiquibaseException - it is used instead to not force callers to change their catch clauses if additional logic is added in the future.

(cherry picked from commit 7792c83)
CockroachDatabase: Do not throw exception when connection is not a Jd…
(cherry picked from commit 848fe3f)
… changes from #1479 to improve bulk query support on more database types

LB-820
Handle exceptions coming from generateSQL DAT-5620
Add custom drop default value statement for postgres.

(cherry picked from commit cdc2e9e)
Make the unexpectedChangeSets command require a changelog LB-375
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1557 (ed4c801) into 4.3.x (4a872f3) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              4.3.x    #1557   +/-   ##
=========================================
  Coverage     49.59%   49.60%           
  Complexity     7863     7863           
=========================================
  Files           757      757           
  Lines         37023    37026    +3     
  Branches       6699     6700    +1     
=========================================
+ Hits          18363    18365    +2     
- Misses        16231    16232    +1     
  Partials       2429     2429           
Impacted Files Coverage Δ Complexity Δ
...quibase/command/core/RegisterChangeLogCommand.java 34.69% <60.00%> (-0.03%) 9.00 <0.00> (ø)
...e/src/main/java/liquibase/util/DependencyUtil.java 92.03% <0.00%> (+0.88%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a872f3...741ab00. Read the comment docs.

@wwillard7800
Copy link
Contributor Author

Closing in order to re-do

@wwillard7800 wwillard7800 deleted the DAT-5699 branch November 24, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants