Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --changeset to have a space in front of it DAT-5604 #1558

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Nov 24, 2020


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

nvoxland and others added 9 commits November 16, 2020 11:19
There is no need to force callers to handle Exception.
The implementation of the close method can currently throw only a DatabaseException. But since the library has a parent exception class - LiquibaseException - it is used instead to not force callers to change their catch clauses if additional logic is added in the future.

(cherry picked from commit 7792c83)
CockroachDatabase: Do not throw exception when connection is not a Jd…
(cherry picked from commit 848fe3f)
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1558 (18202bc) into 4.3.x (4a872f3) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              4.3.x    #1558      +/-   ##
============================================
- Coverage     49.59%   49.59%   -0.01%     
+ Complexity     7863     7862       -1     
============================================
  Files           757      757              
  Lines         37023    37024       +1     
  Branches       6699     6699              
============================================
  Hits          18363    18363              
  Misses        16231    16231              
- Partials       2429     2430       +1     
Impacted Files Coverage Δ Complexity Δ
...uibase-core/src/main/java/liquibase/Liquibase.java 39.88% <ø> (ø) 57.00 <0.00> (ø)
...e/src/main/java/liquibase/hub/core/HttpClient.java 15.09% <0.00%> (ø) 5.00 <0.00> (ø)
...ava/liquibase/database/core/CockroachDatabase.java 52.63% <42.85%> (-2.93%) 6.00 <1.00> (ø)
.../main/java/liquibase/executor/ExecutorService.java 80.55% <100.00%> (ø) 13.00 <1.00> (ø)
...core/formattedsql/FormattedSqlChangeLogParser.java 74.33% <100.00%> (ø) 29.00 <0.00> (ø)
...-core/src/main/java/liquibase/util/ObjectUtil.java 37.43% <0.00%> (-0.56%) 35.00% <0.00%> (-1.00%)
...e/src/main/java/liquibase/util/DependencyUtil.java 92.03% <0.00%> (+0.88%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a872f3...18202bc. Read the comment docs.

@nvoxland nvoxland merged commit 507fdaf into 4.3.x Dec 14, 2020
@nvoxland nvoxland deleted the DAT-5604 branch December 14, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants